When an inlined method refers to method arguments in the true or false #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_505200171
branch
from
6185c7f to
97a6066
Compare
copybara-service
bot
force-pushed
the
test_505200171
branch
from
97a6066 to
308c6a5
Compare
copybara-service
bot
force-pushed
the
test_505200171
branch
from
308c6a5 to
437293d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an inlined method refers to method arguments in the true or false
branch of a conditional statement, refuse to allow it to be inlined.
Before calling the method in question, the caller has definitely
executed the expressions that yield the values passed to the method.
However, after inlining the body of the method into the callsite, one
of the two expressions will no longer be executed, leading to a subtle
behavior change if the un-executed expression was side-effecting.