In StringConcatToTextBlock, don't assume that string literals always have source position information #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…have source position information Annotations on record constructors appear to get desugared early, so string literals on those annotations don't have source positions when they're copied to generated record members. PiperOrigin-RevId: 737721235
copybara-service
bot
force-pushed
the
test_737378851
branch
from
2801812 to
7440ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In StringConcatToTextBlock, don't assume that string literals always have source position information
Annotations on record constructors appear to get desugared early, so string literals on those annotations don't have source positions when they're copied to generated record members.