Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only emit StringConcatToTextBlock findings for source versions that support text blocks #4934

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

copybara-service[bot]
Copy link
Contributor

Only emit StringConcatToTextBlock findings for source versions that support text blocks

Fixes #4931

Copy link
Contributor

@tbroyer tbroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a test for that behavior? (using testHelper.setArgs("--release", "11") ?)

…upport text blocks

Fixes #4931

PiperOrigin-RevId: 739240942
@copybara-service copybara-service bot merged commit e394524 into master Mar 21, 2025
@copybara-service copybara-service bot deleted the test_739191181 branch March 21, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringConcatToTextBlock shouldn't run when using source level that doesn't support text blocks
2 participants