[C++] parser: Add zero_on_float_to_int logic and improve json parsing. #8628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change addresses a fundamental issue when parsing JSON serialized using libraries like cJSON that represent all numbers as
double.Problem Statement
doublevalues in JSON can only represent integers exactly up to 53 bits (2^53 - 1 = 9,007,199,254,740,991)double, causing precision loss ex "1.8446744073709552e+19"Implemented Solution
Instead of failing the entire parsing operation, this change introduces the
zero_on_float_to_intoption that:Use Cases
This is particularly useful for systems that:
Behavior
Test Coverage
The change includes comprehensive test coverage in
ZeroOnFloatToIntTest()to ensure the feature works correctly in both enabled and disabled states.