Improve performance of CreateSharedString by using std::unordered_set instead of std::set #8629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of CreateSharedString uses
std::set
, which has logarithmicfind
runtime. In practice, this is very slow and infeasible if used for many strings. In contrast,std::unordered_set
has an amortized constant lookup time which we found to be much faster.I chose FNV1a because it is fast and has good collision behaviour in general. The downside is that when serializing large quantities of user-supplied strings, the map is now vulnerable to HashDoS attacks. But up until now, the map was so imperformant that supplying any large amount of strings caused a denial of service anyway, so this is clearly an upgrade. If this poses an issue nevertheless, I suggest implementing something like BLAKE3.