-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oi: Version 4.000 added #8353
Oi: Version 4.000 added #8353
Conversation
FontBakery reportfontbakery version: 0.13.0a2 Check results[25] Oi-Regular.ttf🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Does DESCRIPTION file contain broken links?
|
ofl/oi/Oi-Regular.ttf | |
---|---|
Dehinted Size | 541.7kb |
Hinted Size | 541.7kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/kosbarts/Oi
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 14 | 66 | 10 | 162 | 0 |
0% | 0% | 1% | 6% | 26% | 4% | 64% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Ignore all Arabic mark attachment fails. I manually confirmed all of these to work. I don't understand why these reports are generated here. Also ignore the report about ALEF MAKSURA, as the letter only exists in final and isolated form. This is incorrectly reported by The |
Also ignore all Eng fails. This uses the African Eng as default but shaperglot expects the European Eng as default, which needs to be defined in/for shaperglot. |
FontBakery reportfontbakery version: 0.13.0a2 Check results[25] Oi-Regular.ttf🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Does DESCRIPTION file contain broken links?
|
ofl/oi/Oi-Regular.ttf | |
---|---|
Dehinted Size | 541.7kb |
Hinted Size | 541.7kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/kosbarts/Oi
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 14 | 66 | 10 | 162 | 0 |
0% | 0% | 1% | 6% | 26% | 4% | 64% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Update: The ALEF MAKSURA report is accurate, not a mistake, but it doesn't matter in this case. The letter is used in intial and medial form in Uyghur for example, but not in Arabic/Persian/Urdu, which this font here is targetting. We're gonna have to get used to this report for now, as we currently have no way to separate this per glyphset because only one unicode is involved but two presentation forms of it are unnecessary (and uncommon in font files) for the major Arabic script orthographies. |
Also ignore the |
Hi @yanone! I'm not expert in Arabic, so I'm afraid I can't give a precise review for this. However, I noticed this, that looked weird to me: ![]() ![]() It concerns |
That's not specific to Arabic, but an outline issue. I'll look into it, thank you. |
Taken from the upstream repo https://github.com/kosbarts/Oi at commit kosbarts/Oi@5e2b01e. Resolves #8075
Updated |
a244bbe
to
06e3bdc
Compare
FontBakery reportfontbakery version: 0.13.0a2 Check results[25] Oi-Regular.ttf🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Does DESCRIPTION file contain broken links?
|
ofl/oi/Oi-Regular.ttf | |
---|---|
Dehinted Size | 541.8kb |
Hinted Size | 541.8kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/kosbarts/Oi
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 14 | 66 | 10 | 162 | 0 |
0% | 0% | 1% | 6% | 26% | 4% | 64% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Taken from the upstream repo https://github.com/kosbarts/Oi at commit kosbarts/Oi@1938199.
Resolves #8075
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectsprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.