refactor: Crawler/sourcerepos #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZetaTwo
approved these changes
Jun 19, 2023
|
Looks good but there are conflicts |
|
Tests are failing. Please check. |
|
Apologies, should be all set now. |
ZetaTwo
reviewed
Jun 19, 2023
src/gcp_scanner/crawl.py
Outdated
|
|
||
| def list_dns_policies(project_id: str, |
There was a problem hiding this comment.
The rest of the change is about source repos but this lists dns policies? Did you mix up the refactorings?
There was a problem hiding this comment.
Apologies, I didn't realize the merge conflict was caused by #214 - updated crawl.py to match main
ZetaTwo
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #212
ref to #153