Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added integration test boilerplate for get_refresh_token_scope #76

Merged
merged 3 commits into from
Mar 7, 2023
Merged

test: added integration test boilerplate for get_refresh_token_scope #76

merged 3 commits into from
Mar 7, 2023

Conversation

sudiptob2
Copy link
Contributor

@sudiptob2 sudiptob2 commented Mar 2, 2023 •
edited
Loading

Relate to #69

Progress

  • added boilerplate for testing get_scopes_from_refresh_token

Todo

  • implement a way to get credentials inside tests
  • update test/refresh_scopes file

@sudiptob2 sudiptob2 marked this pull request as ready for review March 2, 2023 14:07
mshudrak
mshudrak requested changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@mshudrak mshudrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments. Overall looks good.

@sudiptob2
test: updated docstring typo
02b552e 
Signed-off-by: Sudipto Baral <[email protected]>
@sudiptob2 sudiptob2 requested a review from mshudrak March 6, 2023 16:00
mshudrak
mshudrak requested changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@mshudrak mshudrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. Right now the test is failing. Let's have the test but let's avoid failing for now.

@sudiptob2 sudiptob2 requested a review from mshudrak March 7, 2023 04:06
@mshudrak
Copy link
Collaborator

mshudrak commented Mar 7, 2023

Thanks, merging.

@mshudrak mshudrak merged commit f5f12b4 into google:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshudrak mshudrak mshudrak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudiptob2 @mshudrak