Conversation
Contributor
Author
|
@jinwoo / @blackgnezdo this should be ready to review 🙇 |
Member
|
Thanks, but I'm sorry the CI setup seems broken and I can't tell everything builds fine. I don't have haskell setup handy either and can't verify locally. The changes look good to me. @blackgnezdo, would you be able to take a look and verify? |
Member
|
I realize that the CI was waiting for an approval. I just approved and now it's running. We'll see how it goes. |
Member
|
All tests passed. LGTM. Thanks for the PR, @avdv ! Merging now. |
blackgnezdo
pushed a commit
to blackgnezdo/ghc-source-gen
that referenced
this pull request
Feb 6, 2026
Remove dead commented-out imports left behind by PR google#125 in Expr.hs and Decl.hs. Normalize stack-9.14.yaml to use `resolver:` consistent with other stack config files, and remove informal emoji comment. https://claude.ai/code/session_01KCszpnToh7zEYcuWBj81x3
blackgnezdo
pushed a commit
to blackgnezdo/ghc-source-gen
that referenced
this pull request
Feb 6, 2026
Remove dead commented-out imports left behind by PR google#125 in Expr.hs and Decl.hs. Normalize stack-9.14.yaml to use `resolver:` consistent with other stack config files, and remove informal emoji comment.
blackgnezdo
added a commit
to blackgnezdo/ghc-source-gen
that referenced
this pull request
Feb 6, 2026
Remove dead commented-out imports left behind by PR google#125 in Expr.hs and Decl.hs. Normalize stack-9.14.yaml to use `resolver:` consistent with other stack config files, and remove informal emoji comment.
jinwoo
pushed a commit
that referenced
this pull request
Feb 6, 2026
* Release notes for 0.4.7.0 * Clean up commented-out imports and stack-9.14.yaml style Remove dead commented-out imports left behind by PR #125 in Expr.hs and Decl.hs. Normalize stack-9.14.yaml to use `resolver:` consistent with other stack config files, and remove informal emoji comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft until GHC 9.14.1 is releasedGHC 9.14.1 was released on 19 Dec 2025