Skip to content

Indicate that the code needs pyangbind<0.8.3 - #376

Merged
mike-albano merged 1 commit into
google:masterfrom
JoseIgnacioTamayo:set_pyanbing_version
Jun 3, 2024
Merged

Indicate that the code needs pyangbind<0.8.3#376
mike-albano merged 1 commit into
google:masterfrom
JoseIgnacioTamayo:set_pyanbing_version

Conversation

@JoseIgnacioTamayo

Copy link
Copy Markdown
Collaborator

The bindings in oc_config_validate break with pyangbind>=0.8.3, due to robshakir/pyangbind#297 (the current bindings import bitarray, which pyangbind >= 0.8.3 removed).

This commit enforces a dependency on the pyangbind version for the current code to work. In a future commit, the bindings and this dependency will be updated.

In a future commit, the bindings and this dependency will be updated

@xavier-contreras xavier-contreras left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-albano
mike-albano merged commit 7d8ed7f into google:master Jun 3, 2024
@JoseIgnacioTamayo
JoseIgnacioTamayo deleted the set_pyanbing_version branch June 3, 2024 21:17
@JoseIgnacioTamayo
JoseIgnacioTamayo restored the set_pyanbing_version branch June 3, 2024 21:17
@JoseIgnacioTamayo
JoseIgnacioTamayo deleted the set_pyanbing_version branch June 3, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants