-
Notifications
You must be signed in to change notification settings - Fork 566
feat: add oci image layout mutation #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
+ Coverage 72.92% 73.31% +0.39%
==========================================
Files 118 117 -1
Lines 9417 9017 -400
==========================================
- Hits 6867 6611 -256
+ Misses 1857 1746 -111
+ Partials 693 660 -33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
722bb5e
to
7596331
Compare
e347031
to
c8c1f0f
Compare
Okay, now it's working fine, thanks to @Dentrax. You can test this with the following commands: $ crane pull --format oci devopps/hello-world:buildinfo hello-world-oci-layout
$ tar czf layer.tar.gz README.md
$ LAYER_DIGEST=$(sha256sum layer.tar.gz | cut -d' ' -f1)
$ ./crane mutate --append layer.tar.gz --oci-image-layout hello-world-oci-layout
$ tar tvf hello-world-oci-layout/blobs/sha256/$LAYER_DIGEST
-rw-r--r-- 0 batuhan.apaydin staff 2968 Aug 23 22:59 README.md |
kindly ping @imjasonh @jonjohnsonjr |
kindly ping @jonjohnsonjr |
kindly ping folx @imjasonh @jonjohnsonjr ☝️ |
de84c3c
to
4a79fe4
Compare
kindly ping folx @imjasonh @jonjohnsonjr 🫣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry as always for the delayed review. 🥵
This is quite a lot of new code, which worries me since it doesn't have any corresponding tests, even e2e tests. I'm also not very familiar with the use case, so I'd like to understand that a bit more before committing to supporting this.
Signed-off-by: Batuhan Apaydın <[email protected]> Co-authored-by: Furkan Türkal <[email protected]> Signed-off-by: Batuhan Apaydın <[email protected]>
This Pull Request is stale because it has been open for 90 days with |
Signed-off-by: Batuhan Apaydın [email protected]
Co-authored-by: Furkan Türkal [email protected]
Fixes #1433
kindly ping @imjasonh for review