Improve error message when clientViaApplicationDefaultCredentials fails to log in #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll admit, I'm not sure how to test that. Any suggestion? |
|
@kevmoo Gentle bump :) |
kevmoo
reviewed
Nov 30, 2023
| return await clientViaMetadataServer(baseClient: baseClient); | ||
| } on Exception catch (err, stack) { | ||
| Error.throwWithStackTrace( | ||
| Exception( |
There was a problem hiding this comment.
Hrm...I hate losing the original exception details. I like this idea, though.
Do we have a standarding "inner error" thing somewhere here?
There was a problem hiding this comment.
In our case the error will be a "Failed lookup" error. I'm not sure there's a lot of value.
The stacktrace is preserved, so it should point to what originally threw
I'm not sure how we'd better preserve the chain of error. I'm not aware of an official Dart solution to this problem.
In JS we have that cause field`, but not in Dart? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572