Miscellaneous UI Tweaks #3127
Open
Miscellaneous UI Tweaks #3127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the background of the job selection modal to match current designs.
Adds an enum to control coloring of action buttons dependt on a (for now) binary modality of primary or secondary. Updates the color for secondary actions in the job selection modal accordingly.
Adds a subtle linear gradient to the bottom of the home screen to match the latest UX designs.
gino-m
requested changes
Apr 30, 2025
|
Done, done, done. What did you mean re:
This is in a branch in my ground-android repo -- the branch is called 3078. |
|
Nice work! One nit: is the gradient the same height as in the designs? To my eye it looks like it starts halfway through the "+" fab. Instead, it should start right below the location lock fab like this:
Here are the alpha and color values for reference: 
|
gino-m
requested changes
May 8, 2025
| android:angle="90" | ||
| android:startColor="#601A1C19" | ||
| android:centerColor="#301A1C19" | ||
| android:endColor="#021A1C19" /> |
There was a problem hiding this comment.
The actual gradient is as follows:
Note alpha channel as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of small UI tweaks to make the application match the current UX designs, including:
I didn't get precise numbers on sizing dimensions or gradient values I more or less eyeballed it, so I'm happy to adjust if we have precise values.
Screen.Recording.2025-05-08.at.2.01.43.PM.mov
Towards #3078