Run CodeQL for GitHub Actions & improve workflows #2853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQL support for GitHub Actions is now generally available, see changelog.
This pull request enables scanning of GitHub Actions and improves some of the other workflows. The CIFuzz workflow has been adjusted based on
https://github.com/google/oss-fuzz/blob/cafd7a0eb8ecb4e007c56897996a9b65c49c972f/docs/getting-started/continuous_integration.md, to also upload SARIF results (I don't know exactly how the results, if any, will be shown in the GitHub UI though).
Notes:
queries: +security-and-quality
, which runs additional queries which are not run by default (see documentation)If that causes too many irrelevant alerts, we could consider changing it (either for
actions
only, or also forjava
).In that case the
codeql-analysis.yml
workflow has to be removed and CodeQL scanning has to be enabled in the repository settings.However, 'default setup' seems to use build mode 'none' for Java, and that might not be as accurate, for example because we have the
GsonBuildConfig.java
class which is processed during build.So maybe for now keeping the 'advanced setup' (with explicit workflow) is better?