frontend: support conditionals as scf.if statements #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
j2kun
reviewed
Mar 18, 2025
Comment on lines
+466
to
+468
| import ipdb | ||
|
|
||
| ipdb.set_trace() |
There was a problem hiding this comment.
Suggested change
| import ipdb | |
| ipdb.set_trace() |
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 740397951
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 740397951
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 740397951
Now that we have polynomial evaluation, a lowering for CMP (see #827) should be doable, but we won't be able to run such code in OpenFHE, as it's only feasible for small plaintext moduli which OpenFHE does not (afaik) do. |
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 740397951
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 740397951
Why not use the comparison work from Jelle Vos's paper #920 ? I finally got a chance to read in on the flight to HES and it gives comparison kernels in terms of polynomial evaluation. |
|
edit: sorry misclick |
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 740397951
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 740397951
Good point! The comparison issue predates Jelle's paper by just a few days but I guess it should be updated |
ZenithalHourlyRate
pushed a commit
to ZenithalHourlyRate/heir
that referenced
this pull request
Mar 30, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per google#1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes google#1619 This is actually a part of google#1571 :P PiperOrigin-RevId: 740397951
ZenithalHourlyRate
pushed a commit
to ZenithalHourlyRate/heir
that referenced
this pull request
Apr 1, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per google#1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes google#1619 This is actually a part of google#1571 :P PiperOrigin-RevId: 740397951
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 740397951
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 743164460
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 743164460
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 743164460
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 743164460
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 743164460
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 743164460
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 743164460
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 743164460
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
This stress tests data dependent conditionals lowering all the way to openfhe and translated. I had to modify * fixing subplain's operand ordering per #1619 * heir-translate emitting boolean types * heir-translate allowing extui for boolean extension to avoid canonicalizing arith constant = true -> extui to i64 as a -1 Fixes #1619 This is actually a part of #1571 :P PiperOrigin-RevId: 743164460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: the rlwe pipeline doesn't allow for arith.cmpi so I need some other way of lowering it