Skip to content

Fix node id marshalling for custom string types #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix node id marshalling for custom string types #124

wants to merge 2 commits into from

Conversation

hypnoglow
Copy link
Contributor

Fixes #123

@CrushedPixel
Copy link
Contributor

I need this fix - can we please merge?

@aren55555
Copy link
Contributor

Does this work for Unmarshalling/Deserialization? It would be nice to have a test case that describes the expected results for deserialization.

@hypnoglow hypnoglow force-pushed the bugfix-node-id-string branch from 63dd2a1 to 4309b1d Compare April 27, 2018 14:10
@svanharmelen svanharmelen mentioned this pull request May 29, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hypnoglow hypnoglow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hypnoglow @CrushedPixel @aren55555