fix: infer - arrays should always accept null#49
Conversation
|
This is another behaviour change, so I assume we would also need to wrap it around |
Yes. You can use the same flag value. Also please update the README describing the env var and both effects of this flag. |
|
Actually not the README. doc.go at the bottom. Add a new section: # Controlling behavior changes. |
Following suggestions from @jba google#49 (comment)
|
Done @jba ! Let me know if I should apply further changes. 🙂 |
When building the JSON schema for an array we should always allow "null" since any slice in Go can contain a `nil` value. Resolves google#48
Following suggestions from @jba google#49 (comment)
rafaeljusto
force-pushed
the
null-array
branch
from
7058d13 to
75258da
Compare
* Improve documentation [1] * Improve test coverage [2] [1] https://github.com/google/jsonschema-go/pull/49/files#r2566502953 [2] https://github.com/google/jsonschema-go/pull/49/files#r2542591518
|
Thanks for taking the time to review this and share your feedback, @jba! I’ve applied your suggestion. Let me know if anything else needs adjusting. |
2 participants
When building the JSON schema for an array we should always allow "null" since any slice in Go can contain a
nilvalue.Resolves #48