Embed the license data into the library

[dprotaso]

Thus we no longer need the modcache present for the library to work properly

[dprotaso]

cc @wlynch and @chizhg

[dprotaso]

I tested this out with my fork of go-licenses after I ran go clean -modcache and it worked :)

[dprotaso]

Once this merges go-licenses just requires a go.mod bump

[rspier]

These commits appear to be for the old v1 branch. On v2, I believe we're intentionally not embedding license data.

The description isn't clear, this mostly appears to factor out an interface for monkeypatching.

[dprotaso]

Interesting didn't realize there's a v2 subfolder - go-licenses seems to use v1 atm

[dprotaso]

I think there's still value in shifting v1 away from requiring the mod cache to be present

[dprotaso]

The description isn't clear, this mostly appears to factor out an interface for monkeypatching.

@rspier The intent of the PR is to prevent the license lookup code from reaching into the go mod cache via runtime.Caller(0). This approach is super fragile to the mod cache being present on the system.

The alternative is to use go1.16 embed directives to embed the licenses into the resulting binary that's consuming v1 lib.

You can repro the old behaviour very easily

$ go install github.com/google/go-licenses@latest
$ go-licenses save [package] --save_path=$(mktemp)  --force
$ go clean -modcache
$ go-licenses save [package] --save_path=$(mktemp)  --force
Error: cannot register licenses from archive: open /go/pkg/mod/github.com/google/[email protected]/licenses/licenses.db: no such file or directory ...
....

This issue actually fixes: #27

out an interface for monkeypatching.

I'm assuming you're referring to?

var ReadLicenseFile = licenses.ReadLicenseFile

I left this in place as to not break compatability/API surface

[dprotaso]

@wcn3 any thoughts on this change?

[dprotaso]

bump @wcn3 cc @wlynch

[wcn3]

Upgrading the minimum version and using the embedding feature is a big win.

Note that the v2 API is not baking the archive into the classifier, letting the user use something like this or any other approach to packaging the licenses. I'll adapt this code as a sample contribution to show one way of initializing the v2 classifier.

Apologies for the delays here. My Github notifications were going to an email that got blackholed. Thank you for making this improvement!