fix(coordinate_space): handle nearly integer-aligned bounds #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, coordinate bounds approximately, but not exactly, equal to an integer or half-integer were handled poorly. In particular, the lower/upper bounds could end up off by 1 from the expected value, and voxelCenterAtIntegerCoordinates could end up false when it was expected to be true, leading to coordinates snapping to the boundary between two voxels, rather than the center, as expected. With this change, coordinate bounds within 1e-3 of an integer or half-integer are handled properly. Fixes #719.
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, coordinate bounds approximately, but not exactly, equal to an integer or half-integer were handled poorly.
In particular, the lower/upper bounds could end up off by 1 from the expected value, and voxelCenterAtIntegerCoordinates could end up false when it was expected to be true, leading to coordinates snapping to the boundary between two voxels, rather than the center, as expected.
With this change, coordinate bounds within 1e-3 of an integer or half-integer are handled properly.
Fixes #719.