Add Ssh widget #4506
Add Ssh widget #4506
Conversation
| ABSL_FLAG(bool, nodeploy, false, "Disable automatic deployment of OrbitService"); | ||
| ABSL_FLAG(bool, signed_debian_package_deployment, false, | ||
| "Deploy OrbitService via the Signed debian package deployment method. (Use this for " | ||
| "connecting to a Stadia instance)."); |
There was a problem hiding this comment.
Should we be more generic and not mention Stadia here?
| } | ||
|
|
||
| std::optional<orbit_ssh::AddrAndPort> ConnectToSshWidget::GetTargetAddrAndPort() const { | ||
| if (!ssh_connection_.has_value()) return std::nullopt; |
There was a problem hiding this comment.
Nit: Consider making this a single line using '?' and ':'
| .root_password)); | ||
| } | ||
| if (std::holds_alternative<SignedDebianPackageDeployment>(deployment_configuration_)) { | ||
| ui_->signedDeploymentButton->setVisible(true); |
There was a problem hiding this comment.
I don't understand why we are setting this to true here and not in the constructor.
|
|
||
| 1. Start Orbit via | ||
| Alternatively you can use command line flags to automate the connection setup. This |
There was a problem hiding this comment.
This is also true for LocalProfiling? Because if not I would remove it entirely.
There was a problem hiding this comment.
Yes. I would argue this is true. You can use the --process_name option and then bypass the connection window - also when local profiling.
and choose the BareExecutableAndRootPasswordDeployment when either `--collector` or `--collector_root_password` is specified. Beforehand the signed deployment was default and both needed to be specified.
Note: This commit does not include unit tests. ServiceDeployManager is currently not mockable, so only part of the functionality could be tested.
into SessionSetupDialog and add convenience method to TargetLabel
Well, we can of course add some empty space. Do you have an idea on how it should look like? I really don't have an opinion about this and wouldn't know what to change. |
This is the last PR for the "generic SSH" UI. This adds and integrates ConnectToSshWidget and updates documentation.
The PR is split up in 4 commits to make the review a bit easier. There are meaningful commit messages. Please look at the documentation commit for screenshots.
@karupayun This is a lot of code doing quite some things, we can also go through this together tomorrow in our 1:1:1 if there are questions.