This repository was archived by the owner on Jan 31, 2025. It is now read-only.
Change TrackManager::GetOrCreate* to std::string_view #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some GetOrCreate<Something>Track functions in TrackManager used to take a const std::string&. Changing that to std::string_view was to intrusive for the huge mechanical change that switched everything to std::string_view. So this PR follows up on the missing parts. It enables transparent comparison for `async_tracks_` and `variable_tracks` and rearranges the code so that it follows our return early guideline.
beckerhe
commented
Dec 5, 2022
Comment on lines
-118
to
+120
| std::map<std::string, std::shared_ptr<AsyncTrack>> async_tracks_; | ||
| std::map<std::string, std::shared_ptr<VariableTrack>> variable_tracks_; | ||
| std::map<std::string, std::shared_ptr<AsyncTrack>, std::less<>> async_tracks_; | ||
| std::map<std::string, std::shared_ptr<VariableTrack>, std::less<>> variable_tracks_; |
There was a problem hiding this comment.
This change is needed for transparent comparison (for tracks_.find() to accept a std::string_view even though the key type is std::string).
karupayun
approved these changes
Dec 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GetOrCreateTrack functions in TrackManager used to take a const std::string&. Changing that to std::string_view was to intrusive for the huge mechanical change that switched everything to std::string_view.
So this PR follows up on the missing parts. It enables transparent comparison for
async_tracks_andvariable_tracksand rearranges the code so that it follows our return early guideline.