Skip to content

feat: manifest reader for Python requirements #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cuixq
Copy link
Collaborator

@cuixq cuixq commented Jun 25, 2025

#853

This PR adds a basic manifest reader for Python requirements file.

@cuixq cuixq marked this pull request as ready for review June 25, 2025 03:44
@cuixq cuixq requested a review from michaelkedar June 25, 2025 03:44
Copy link
Member

@michaelkedar michaelkedar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge as-is, but just flagging a few small things that may or may not cause problems in the future.


// SupportedStrategies returns the remediation strategies supported for this manifest.
func (r readWriter) SupportedStrategies() []strategy.Strategy {
// TODO(#853): add relax and in-place strategy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the in-place strategy relies on the lockfile.ReadWriter interface, which is a bit different to the manifest one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants