Use pdl-compiler directly #1
Conversation
|
May not be needed after google/pdl#61. |
marshallpierce
force-pushed
the
mp/pdlc-as-library
branch
from
6ba7380 to
8c8b45c
Compare
| - name: Install dependencies | ||
| run: | | ||
| cargo install pdl-compiler --version 0.2.2 | ||
| cargo install pdl-compiler --version 0.2.3 |
There was a problem hiding this comment.
I'm assuming it's desirable for pdl-compiler to be up to date -- if you'd rather stick with 0.2.2 that's fine too of course
|
|
||
| // Find the pdl tool. Expecting it at CARGO_HOME/bin | ||
| let pdl = match env::var("CARGO_HOME") { | ||
| let pdlc = match env::var("CARGO_HOME") { |
There was a problem hiding this comment.
Is it even desirable to maintain this code path? If someone is using Cargo vs the Blaze build, when would they want to use the external pdlc? Or perhaps should it be present to allow hypothetical debugging of issues specific to a pdlc binary, but only used if an env var is set?
|
|
||
| - name: Check Cargo build | ||
| run: | | ||
| cargo test |
There was a problem hiding this comment.
might as well check that the cargo build works 🤷
If the `pdlc` binary is not available, use `pdl_compiler` as a library instead. Also do some misc tidying of the build script, since it looks like the output path was being derived in different ways with the same result.
marshallpierce
force-pushed
the
mp/pdlc-as-library
branch
from
8c8b45c to
4556d39
Compare
|
This change is obsolete, has been applied independently on AOSP. |
2 participants
If the
pdlcbinary is not available, usepdl_compileras a library instead.Also do some misc tidying of the build script, since it looks like the output path was being derived in different ways with the same result.