docs: clarify map(parseInt) example with explicit radix #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an arrow-function callback to explicitly forward only the string and a radix of 10 to parseInt: ```js // GOOD: we only forward the string (and an explicit radix) ['11','5','3'].map(n => parseInt(n, 10)); // [11, 5, 3]
vapier
requested changes
Apr 24, 2025
Shorten the “GOOD” example comment to its original concise form, per maintainer feedback:
|
i checked internally and it looks like we also ran into this issue. unfortunately they switched to using an internal API, so i've asked them to tweak it again to address your feedback while being usable externally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an arrow-function callback to explicitly forward only the string and a radix of 10 to parseInt:
// GOOD: we only forward the string (and an explicit radix)
['11','5','3'].map(n => parseInt(n, 10)); // [11, 5, 3]