Add simple RLE encoding pipeline #1005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `top` flag exposed by the opt_main was not added to the list of available flags in the bazel rules. This addition allows the `top` flag to be used as an argument in the xls_dslx_verilog::opt_ir_args parameter. Signed-off-by: Robert Winkler <[email protected]>
Currently, only a simple implementation is provided, which has no optimizations related to the RLE algorithm. The provided tests check if: * output of the encoder matches the expected values * sum of received symbols adds up to the amount of sent symbols * received symbols don't repeat unless the RLE counter overflowed or the end of transmission was requested (using `last` flag) Additional bazel rules added in this commit include: * Verilog code generation * IR benchmark generation * Verilog benchmark generation Internal-tag: [#44560] Signed-off-by: Robert Winkler <[email protected]>
Signed-off-by: Maciej Dudek <[email protected]>
This commit moves intra RLE channel definitions to rl_interface.x file. This allows for easier control over interface changes. Signed-off-by: Maciej Dudek <[email protected]>
Signed-off-by: Maciej Dudek <[email protected]>
This proc muxes RLE encoder output (symbols and counters) into stream of words, where symbols and counters are interleaved together. Signed-off-by: Maciej Dudek <[email protected]>
This commit adds a simple RLE encoding pipeline. It combines RLE encoder with stream muxer. It converts stream of symbols into stream of interleaved symbols and counts. This commit adds simple tests to check RLE encoder with stream muxer processing pipeline. Signed-off-by: Maciej Dudek <[email protected]>
|
Do want to land #974 first? or should we start reviewing now? |
|
It seems we are close to merging #974, so that we can start reviewing this soon. |
|
can we decouple this from #1012? |
|
I'm closing this PR, as it's not necessary to have basic RLE implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds example of simple RLE encoding pipeline.
It uses RLE encoder from #974 and stream muxer form #1004.
Depends on:
Related: #994
CC @proppy