[Proc-scoped channels] Support spawning the same proc with the same parametrics but different channels. This was done by getting all instantiations of the config function for a given parametric from TypeInfo. These are now keyed on both the instantiation and the parametric env; otherwise it was not picking the right ones.
#3211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arametrics but different channels. This was done by getting all instantiations of the config function for a given parametric from `TypeInfo`. These are now keyed on both the instantiation and the parametric env; otherwise it was not picking the right ones. Give a unique name for each `proc_instantiation` node (spawn) in a given `config`. PiperOrigin-RevId: 820712897
copybara-service
bot
force-pushed
the
test_820712897
branch
from
8045b4c to
45f7c6b
Compare
copybara-service
bot
changed the title
TypeInfo.TypeInfo. These are now keyed on both the instantiation and the parametric env; otherwise it was not picking the right ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Proc-scoped channels] Support spawning the same proc with the same parametrics but different channels. This was done by getting all instantiations of the config function for a given parametric from
TypeInfo. These are now keyed on both the instantiation and the parametric env; otherwise it was not picking the right ones.Give a unique name for each
proc_instantiationnode (spawn) in a givenconfig.