-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bringing in service account string capability #871
base: main
Are you sure you want to change the base?
Conversation
…unt_option Bringing service account string option
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…unt_option small flow fix
…unt_option Srijan/bring service account option
@dmosorast, @dsprayberry, @Vi6hal, @bryantgray would love your take on this PR, thanks! |
Description:
This PR adds the ability to provide credentials via an environment variable for use cases where adding a .json to the filesystem in the runtime environment is not feasible for security reasons.
Testing:
Called get_credentials in oauth2.py by declaring a
"json_key_string"
(item) with personal credentials inconfig_data
(dictionary)The result was that we received as a valid credentials object.
References:
Would highly recommend seeing this as similar approach has been executed in big query api library!
BQ: https://github.com/anelendata/tap-bigquery/blob/master/tap_bigquery/sync_bigquery.py
Implementation: https://gitlab.1password.io/data/data-issues/-/issues/3347#note_3160542