Gold test for examples/billing #992
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing` directory. Specifically, `get_invoices.py`, `add_account_budget_proposal.py`, and `add_billing_setup.py` now have corresponding tests in `examples/billing/tests/`. These tests use `unittest.mock` to simulate interactions with the Google Ads API. This helps ensure your example scripts are making the correct service calls and handling responses as you expect. I also confirmed that all examples in `examples/billing` already explicitly initialize the `GoogleAdsClient` with `version="v19"`. During the development of these tests, I made minor corrections to `get_invoices.py` to fix a `NameError` and an attribute error on a mocked object.
bobhancockg
requested review from
Raibaz and
dorasun
and removed request for
Raibaz and
dorasun
BenRKarl
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
BenRKarl
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing
directory. Specifically,get_invoices.py,add_account_budget_proposal.py, andadd_billing_setup.pynow have corresponding tests inexamples/billing/tests/`.These tests use
unittest.mockto simulate interactions with the Google Ads API. This helps ensure your example scripts are making the correct service calls and handling responses as you expect.I also confirmed that all examples in
examples/billingalready explicitly initialize theGoogleAdsClientwithversion="v19".During the development of these tests, I made minor corrections to
get_invoices.pyto fix aNameErrorand an attribute error on a mocked object.