change from deprecated ...set_option to set_options #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In php8.4 stream_context_set_option no longer supports the signature with two arguments. Therefor the alternative function stream_context_set_options needs to be used. source: https://www.php.net/manual/en/function.stream-context-set-option.php Also implicitly marking parameters as nullable is deprecated. Signed-off-by: Spirit-act <[email protected]>
Signed-off-by: Spirit-act <[email protected]>
|
Looks like this will fix #805. Any estimate date when this will be merged? Thanks!! |
Merge branch 'main' into soap-php8.4 - remove 202408 - add 202505 - add fixes to 202505 Signed-off-by: Spirit-act <[email protected]>
stream_context_set_options only exists since php8.3.0. This Commit intruces a check for the php version. If the version is greater or equal than 8.3.0 it uses stream_context_set_options. Otherwise it uses stream_context_set_option. Signed-off-by: Spirit-act <[email protected]>
the php version id check for backwards compatibility had one digit to much. Signed-off-by: Spirit-act <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In php8.4 stream_context_set_option no longer supports the signature with two arguments. Therefor the alternative function stream_context_set_options needs to be used.
source: https://www.php.net/manual/en/function.stream-context-set-option.php
Also implicitly marking parameters as nullable is deprecated.
The implicit nullable is only changed by files, which I use within my script, because only these I could validate.
Edit:
In the last commit a check for the PHP version was added. If the PHP version is greater or equal to PHP 8.3.0
stream_context_set_optionsis used. If the version is lowerstream_context_set_optionis used.It feels a bit ugly, but i did not find a better solution for backwards compatibility.