feat: Introduce a way to provide custom headers #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| import copy | ||
|
|
||
| PROTECTED_HEADERS = { |
There was a problem hiding this comment.
Is there a way to capture this in a more central way? I worry that we are missing some now or may miss some in the future if new ones get added
for example
| creds_with_header.before_request(request, "http://example.com", "GET", headers) | ||
| assert headers["X-Custom-Header"] == "value1" | ||
| assert "authorization" in headers # Ensure base apply logic ran | ||
| assert creds_with_header is not credentials |
There was a problem hiding this comment.
Not sure what you're trying to test here but as I understand python, this will never be true.
i.e. if you did:
credentials_a = CredentialsImpl()
credentials_b = CredentialsImpl()
assert credentials_a is not credentials_b # success
| assert c._use_non_blocking_refresh | ||
|
|
||
|
|
||
| def test_with_headers(): |
There was a problem hiding this comment.
nit: this test is testing multiple scenarios. could you break it up so that we are testing ~1 thing per test?
https://engdoc.corp.google.com/eng/doc/tott/episodes/726.md?cl=head
|
|
||
| self._use_non_blocking_refresh = False | ||
| self._refresh_worker = RefreshThreadManager() | ||
| self._custom_headers = {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain scenarios, custom headers are required to be sent to the backend along with usual headers like
authorization,x-goog-user-project. Exposing a way for users to specify these custom headers.