Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(rest): support LRO operation types without name method #14924

Merged

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Jan 10, 2025

Unlike Compute, BigQuery LRO Operation types don't have a name method. This PR adds a mechanism to provide a function to get the name from the Operation.


This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner January 10, 2025 01:19
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.91%. Comparing base (bbb1355) to head (0e82dac).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ud/internal/async_rest_polling_loop_custom_test.cc 91.22% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14924   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files        2351     2351           
  Lines      209741   209811   +70     
=======================================
+ Hits       194883   194955   +72     
+ Misses      14858    14856    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scotthart scotthart merged commit 90d72c0 into googleapis:main Jan 10, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants