Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update documentation to point to security best practice #14942

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

cuiy0006
Copy link
Collaborator

@cuiy0006 cuiy0006 commented Jan 16, 2025

This change is Reviewable

@cuiy0006 cuiy0006 requested a review from a team as a code owner January 16, 2025 19:08
@cuiy0006 cuiy0006 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (63bc533) to head (b9cc1e3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14942   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files        2351     2351           
  Lines      210082   210082           
=======================================
+ Hits       195202   195203    +1     
+ Misses      14880    14879    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @cuiy0006)


google/cloud/credentials.h line 122 at r2 (raw file):

 *   credentials.
 *
 * Important: If you accept a credential configuration (credential

s/Important:/@warning

This will add some additional highlighting during doc rendering.

Code quote:

Important:

google/cloud/credentials.h line 276 at r2 (raw file):

 * Azure, or SAML 2.0.
 *
 * Important: If you accept a credential configuration (credential

s/Important:/@warning

This will add some additional highlighting during doc rendering.

Code quote:

Important:

@scotthart scotthart removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 22, 2025
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @cuiy0006)

@scotthart scotthart merged commit 6af1613 into googleapis:main Jan 22, 2025
74 of 75 checks passed
@cuiy0006 cuiy0006 deleted the add-warning-3rd-party-credential branch January 23, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants