Skip to content

Commit

Permalink
feat!: Removed dependency on google-cloud-secret_manager-v1beta1 prer…
Browse files Browse the repository at this point in the history
…elease service (#29004)

feat: Updated google-cloud-secret_manager-v1 dependency to version 1.x
  • Loading branch information
gcf-owl-bot[bot] authored Feb 12, 2025
1 parent 49c6ad7 commit 093de47
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 8 deletions.
22 changes: 21 additions & 1 deletion google-cloud-secret_manager/.owlbot-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@
"samples/acceptance/add_regional_secret_version_test.rb",
"samples/acceptance/add_secret_version_test.rb",
"samples/acceptance/create_regional_secret_test.rb",
"samples/acceptance/create_regional_secret_with_annotations_test.rb",
"samples/acceptance/create_regional_secret_with_labels_test.rb",
"samples/acceptance/create_secret_test.rb",
"samples/acceptance/create_secret_with_annotations_test.rb",
"samples/acceptance/create_secret_with_labels_test.rb",
"samples/acceptance/create_ummr_secret_test.rb",
"samples/acceptance/delete_regional_secret_test.rb",
"samples/acceptance/delete_regional_secret_with_etag_test.rb",
Expand All @@ -40,6 +44,8 @@
"samples/acceptance/disable_regional_secret_version_test.rb",
"samples/acceptance/disable_regional_secret_version_with_etag_test.rb",
"samples/acceptance/disable_secret_version_test.rb",
"samples/acceptance/edit_regional_secret_annotations_test.rb",
"samples/acceptance/edit_secret_annotations_test.rb",
"samples/acceptance/enable_regional_secret_version_test.rb",
"samples/acceptance/enable_regional_secret_version_with_etag_test.rb",
"samples/acceptance/enable_secret_version_test.rb",
Expand Down Expand Up @@ -68,12 +74,20 @@
"samples/acceptance/update_regional_secret_with_etag_test.rb",
"samples/acceptance/update_secret_test.rb",
"samples/acceptance/update_secret_with_alias_test.rb",
"samples/acceptance/view_regional_secret_annotations_test.rb",
"samples/acceptance/view_regional_secret_labels_test.rb",
"samples/acceptance/view_secret_annotations_test.rb",
"samples/acceptance/view_secret_labels_test.rb",
"samples/access_regional_secret_version.rb",
"samples/access_secret_version.rb",
"samples/add_regional_secret_version.rb",
"samples/add_secret_version.rb",
"samples/create_regional_secret.rb",
"samples/create_regional_secret_with_annotations.rb",
"samples/create_regional_secret_with_labels.rb",
"samples/create_secret.rb",
"samples/create_secret_with_annotations.rb",
"samples/create_secret_with_labels.rb",
"samples/create_ummr_secret.rb",
"samples/delete_regional_secret.rb",
"samples/delete_regional_secret_with_etag.rb",
Expand All @@ -84,6 +98,8 @@
"samples/disable_regional_secret_version.rb",
"samples/disable_regional_secret_version_with_etag.rb",
"samples/disable_secret_version.rb",
"samples/edit_regional_secret_annotations.rb",
"samples/edit_secret_annotations.rb",
"samples/enable_regional_secret_version.rb",
"samples/enable_regional_secret_version_with_etag.rb",
"samples/enable_secret_version.rb",
Expand All @@ -109,6 +125,10 @@
"samples/update_regional_secret_with_alias.rb",
"samples/update_regional_secret_with_etag.rb",
"samples/update_secret.rb",
"samples/update_secret_with_alias.rb"
"samples/update_secret_with_alias.rb",
"samples/view_regional_secret_annotations.rb",
"samples/view_regional_secret_labels.rb",
"samples/view_secret_annotations.rb",
"samples/view_secret_labels.rb"
]
}
2 changes: 1 addition & 1 deletion google-cloud-secret_manager/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ source "https://rubygems.org"

gemspec

local_dependencies = ["google-cloud-secret_manager-v1", "google-cloud-secret_manager-v1beta1"]
local_dependencies = ["google-cloud-secret_manager-v1"]

main_spec = gemspecs.last || Bundler.load_gemspec(File.join(__dir__, "google-cloud-secret_manager.gemspec"))
local_dependencies.each do |name|
Expand Down
6 changes: 2 additions & 4 deletions google-cloud-secret_manager/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ for this library, google-cloud-secret_manager, to see the convenience methods fo
constructing client objects. Reference documentation for the client objects
themselves can be found in the client library documentation for the versioned
client gems:
[google-cloud-secret_manager-v1](https://cloud.google.com/ruby/docs/reference/google-cloud-secret_manager-v1/latest),
[google-cloud-secret_manager-v1beta1](https://cloud.google.com/ruby/docs/reference/google-cloud-secret_manager-v1beta1/latest).
[google-cloud-secret_manager-v1](https://cloud.google.com/ruby/docs/reference/google-cloud-secret_manager-v1/latest).

See also the [Product Documentation](https://cloud.google.com/secret-manager)
for more usage information.
Expand Down Expand Up @@ -63,8 +62,7 @@ results in logs appearing alongside your application logs in the
Debug logging also requires that the versioned clients for this service be
sufficiently recent, released after about Dec 10, 2024. If logging is not
working, try updating the versioned clients in your bundle or installed gems:
[google-cloud-secret_manager-v1](https://cloud.google.com/ruby/docs/reference/google-cloud-secret_manager-v1/latest),
[google-cloud-secret_manager-v1beta1](https://cloud.google.com/ruby/docs/reference/google-cloud-secret_manager-v1beta1/latest).
[google-cloud-secret_manager-v1](https://cloud.google.com/ruby/docs/reference/google-cloud-secret_manager-v1/latest).

## Supported Ruby Versions

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@ Gem::Specification.new do |gem|
gem.required_ruby_version = ">= 3.0"

gem.add_dependency "google-cloud-core", "~> 1.6"
gem.add_dependency "google-cloud-secret_manager-v1", ">= 0.19", "< 2.a"
gem.add_dependency "google-cloud-secret_manager-v1beta1", ">= 0.3", "< 2.a"
gem.add_dependency "google-cloud-secret_manager-v1", "~> 1.2"
end

0 comments on commit 093de47

Please sign in to comment.