-
Notifications
You must be signed in to change notification settings - Fork 30
ci: make it easy to change the dependencies via "mvn version:set-property" #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
suztomo
wants to merge
8
commits into
main
Choose a base branch
from
maven_ci_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
reviewed
Nov 20, 2025
Comment on lines
+30
to
+37
| echo "mvn dependency:tree for google-cloud-logging and gax" | ||
| mvn dependency:tree -Dverbose -Dincludes=com.google.cloud:google-cloud-logging,com.google.api:gax | ||
|
|
||
| echo "mvn help:effective-pom" | ||
| mvn help:effective-pom -Dverbose | ||
|
|
||
| echo "Installing the project" | ||
|
|
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, while it's not strictly needed, the commands are here to confirm the effect of dependency changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: logging
Issues related to the googleapis/java-logging-logback API.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it easy to run tests with controlled dependencies via Maven properties.
This change is helpful in both pull request approach and branch approach. For example, we can update the version of the google-cloud-logging dependency by
mvn versions:set-property -DpropertiesVersionsFile=dependency-upgrade.propertieswheredependency-upgrade.propertieshas:https://www.mojohaus.org/versions/versions-maven-plugin/set-property-mojo.html
Note that java-logging-logback will use only
google-cloud-logging.versionproperty but the command accepts multiple entries there..mvn/maven.config v.s. mvn versions:set-property
Both approach can create a commit to run builds. I prefer
mvn versions:set-propertybecause the resulting pull request is mergeable.We cannot use a property for the parent pom version
A site note: I tried to use a property in the parent pom version, but it did not work: