fix: retry as PDML dit not retry Resource limit exceeded

[olavloite]

Most transactions that exceed the mutation limit for an atomic transaction will fail with the error "The transaction contains too many mutations.". However, it is also possible that the transaction fails with the more generic error message "Transaction resource limits exceeded". This error did not trigger a retry of the statement using a PDML transaction.

Fixes #4253

[gemini-code-assist]

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where transactions failing due to a generic 'Transaction resource limits exceeded' error were not being retried using Partitioned DML (PDML). By extending the TransactionMutationLimitExceededException to recognize this broader error message, the system can now correctly identify and retry these transactions, improving the robustness of operations that might exceed resource limits.

Highlights

• Expanded Exception Recognition: The TransactionMutationLimitExceededException now correctly identifies transactions failing with the generic 'Transaction resource limits exceeded' error message, in addition to the more specific 'The transaction contains too many mutations' error.
• Enabled PDML Retries: This change ensures that transactions encountering the 'Transaction resource limits exceeded' error will now correctly trigger a retry using Partitioned DML (PDML), improving resilience.
• Parameterized Tests: Existing test cases for PDML retry logic have been updated to be parameterized, allowing them to validate the behavior for both the specific mutation limit exceeded error and the newly recognized generic resource limit exceeded error.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new error message, "Transaction resource limits exceeded," to the TransactionMutationLimitExceededException class, allowing it to recognize this message in addition to the existing "The transaction contains too many mutations" message. The isTransactionMutationLimitException methods were updated to check for both error strings. Correspondingly, the RetryDmlAsPartitionedDmlMockServerTest test suite was refactored to be parameterized, enabling existing tests to run against both the original mutation limit exceeded exception and the newly recognized resource limit exceeded exception, ensuring consistent behavior for both scenarios.