feat: next release is v6.105.0-rc1 #4260

diegomarquezp · 2025-12-10T20:07:38Z

Includes sync with main, with commits 7b49412 and c735d42

#4252) * fix: Refine connecitivity metrics to capture RPCs with no response headers * test fix

Most transactions that exceed the mutation limit for an atomic transaction will fail with the error "The transaction contains too many mutations.". However, it is also possible that the transaction fails with the more generic error message "Transaction resource limits exceeded". This error did not trigger a retry of the statement using a PDML transaction. Fixes #4253

gemini-code-assist · 2025-12-10T20:08:10Z

Summary of Changes

Hello @diegomarquezp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on internal improvements to the Google Cloud Spanner client library, specifically around how network latency metrics (GFE and AFE) are collected and reported, and how transaction limit exceptions are identified. The changes involve a significant refactoring of the metrics recording pipeline, moving header processing and metric recording to a more appropriate lifecycle stage within the gRPC interceptor. Additionally, it broadens the recognition of transaction mutation limit exceptions to include a more general resource limit message. These updates aim to enhance the accuracy and robustness of internal monitoring and error handling mechanisms, preparing the library for a new release candidate.

Highlights

Metrics Refactoring: Significant refactoring of how GFE (Google Front End) and AFE (Application Front End) latency metrics and missing header counts are recorded. This includes changes in BuiltInMetricsRecorder, BuiltInMetricsTracer, CompositeTracer, and HeaderInterceptor to streamline the process and make it more robust.
Transaction Limit Exception Handling: Enhanced the TransactionMutationLimitExceededException to also recognize a more generic "Transaction resource limits exceeded" message, improving the robustness of error handling.
Clirr Configuration Update: Updated the clirr-ignored-differences.xml to ignore breaking changes related to the removal of unused internal methods from the CompositeTracer interface.
Test Suite Enhancements: Modified several test files to align with the metric recording changes and to parameterize tests for transaction limit exceptions, ensuring comprehensive coverage.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request prepares for the next release, v6.105.0-rc1. The changes primarily involve refactoring the built-in metrics recording logic, especially around server timing headers. This refactoring centralizes the logic, making it more robust and easier to maintain. The changes also include support for a new 'Transaction resource limits exceeded' error message.

My review has identified a couple of issues:

Incorrect logging format in HeaderInterceptor.java which would prevent log messages from being formatted correctly.
Use of wildcard imports in several files, which is against common Java style guidelines.
A minor formatting issue in an XML configuration file.

I've provided suggestions to fix these issues. Overall, the refactoring is a good improvement.

gemini-code-assist · 2025-12-10T20:09:47Z

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java

+                    gfeLatency = serverTimingMetrics.get(GFE_TIMING_HEADER);
+                    afeLatency = serverTimingMetrics.get(AFE_TIMING_HEADER);
+                  } catch (NumberFormatException e) {
+                    LOGGER.log(LEVEL, "Invalid server-timing object in header: {}", serverTiming);


The logging format {} is for SLF4J, but java.util.logging.Logger is being used here. The correct format for java.util.logging.Logger is to use indexed placeholders like {0}. Using the wrong format will result in the placeholder being printed literally instead of being replaced by the variable's value.

Suggested change

LOGGER.log(LEVEL, "Invalid server-timing object in header: {}", serverTiming);

LOGGER.log(LEVEL, "Invalid server-timing object in header: {0}", serverTiming);

gemini-code-assist · 2025-12-10T20:09:47Z

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java

+                    LOGGER.log(
+                        LEVEL, "Unable to get built-in metric attributes {}", e.getMessage());


The logging format {} is for SLF4J, but java.util.logging.Logger is being used here. The correct format for java.util.logging.Logger is to use indexed placeholders like {0}. Using the wrong format will result in the placeholder being printed literally instead of being replaced by the variable's value.

Suggested change

LOGGER.log(

LEVEL, "Unable to get built-in metric attributes {}", e.getMessage());

LOGGER.log(

LEVEL, "Unable to get built-in metric attributes {0}", e.getMessage());

gemini-code-assist · 2025-12-10T20:09:47Z

google-cloud-spanner/clirr-ignored-differences.xml

+    <differenceType>7002</differenceType>
+    <className>com/google/cloud/spanner/CompositeTracer</className>
+    <method>void recordGFELatency(java.lang.Float)</method>
+  </difference><difference>


For better readability and to maintain consistent XML formatting, it's recommended to place each <difference> tag on a new line.

Suggested change

</difference><difference>

</difference>

<difference>

gemini-code-assist · 2025-12-10T20:09:47Z

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java

-import io.grpc.Channel;
-import io.grpc.ClientCall;
-import io.grpc.ClientInterceptor;
+import io.grpc.*;


To improve code clarity and avoid potential naming conflicts, it's a good practice to use explicit imports instead of wildcard imports. Please replace import io.grpc.*; with the specific classes used from the package.

Suggested change

import io.grpc.*;

import io.grpc.CallOptions;

import io.grpc.Channel;

import io.grpc.ClientCall;

import io.grpc.ClientInterceptor;

import io.grpc.Metadata;

import io.grpc.MethodDescriptor;

import io.grpc.Status;

gemini-code-assist · 2025-12-10T20:09:47Z

google-cloud-spanner/src/test/java/com/google/cloud/spanner/spi/v1/GfeLatencyTest.java

 import static com.google.cloud.spanner.DisableDefaultMtlsProvider.disableDefaultMtlsProvider;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.*;


To improve code clarity and avoid potential naming conflicts, it's a good practice to use explicit imports instead of wildcard imports. Please replace import static org.junit.Assert.*; with the specific static methods used.

Suggested change

import static org.junit.Assert.*;

import static org.junit.Assert.assertEquals;

import static org.junit.Assert.assertNotNull;

import static org.junit.Assert.assertTrue;

gemini-code-assist · 2025-12-10T20:09:47Z

google-cloud-spanner/src/test/java/com/google/cloud/spanner/spi/v1/GfeLatencyTest.java

-import org.junit.AfterClass;
-import org.junit.BeforeClass;
-import org.junit.Test;
+import org.junit.*;


To improve code clarity and avoid potential naming conflicts, it's a good practice to use explicit imports instead of wildcard imports. Please replace import org.junit.*; with the specific classes used from the package.

Suggested change

import org.junit.*;

import org.junit.After;

import org.junit.AfterClass;

import org.junit.BeforeClass;

import org.junit.Test;

gemini-code-assist · 2025-12-10T20:09:47Z

google-cloud-spanner/src/test/java/com/google/cloud/spanner/spi/v1/SpannerRpcMetricsTest.java

-import org.junit.AfterClass;
-import org.junit.BeforeClass;
-import org.junit.Test;
+import org.junit.*;


To improve code clarity and avoid potential naming conflicts, it's a good practice to use explicit imports instead of wildcard imports. Please replace import org.junit.*; with the specific classes used from the package.

Suggested change

import org.junit.*;

import org.junit.After;

import org.junit.AfterClass;

import org.junit.BeforeClass;

import org.junit.Test;

diegomarquezp and others added 3 commits December 10, 2025 20:04

feat: next release is v6.105.0-rc1

381c86b

fix: Refine connecitivity metrics to capture RPCs with no response he… (

c5f1af7

#4252) * fix: Refine connecitivity metrics to capture RPCs with no response headers * test fix

diegomarquezp requested review from a team as code owners December 10, 2025 20:07

product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 10, 2025

gemini-code-assist bot reviewed Dec 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: next release is v6.105.0-rc1 #4260

feat: next release is v6.105.0-rc1 #4260

Uh oh!

diegomarquezp commented Dec 10, 2025

Uh oh!

gemini-code-assist bot commented Dec 10, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 10, 2025

Uh oh!

gemini-code-assist bot Dec 10, 2025

Uh oh!

gemini-code-assist bot Dec 10, 2025

Uh oh!

gemini-code-assist bot Dec 10, 2025

Uh oh!

gemini-code-assist bot Dec 10, 2025

Uh oh!

gemini-code-assist bot Dec 10, 2025

Uh oh!

gemini-code-assist bot Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	LOGGER.log(LEVEL, "Invalid server-timing object in header: {}", serverTiming);
	LOGGER.log(LEVEL, "Invalid server-timing object in header: {0}", serverTiming);

		LOGGER.log(
		LEVEL, "Unable to get built-in metric attributes {}", e.getMessage());

feat: next release is v6.105.0-rc1 #4260

Are you sure you want to change the base?

feat: next release is v6.105.0-rc1 #4260

Uh oh!

Conversation

diegomarquezp commented Dec 10, 2025

Uh oh!

gemini-code-assist bot commented Dec 10, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants