Skip to content

feat: add checkpoint aget tuple method#281

Merged
averikitsch merged 2 commits intogoogleapis:langgraph-basefrom
carloszuag:feat/aget_tuple_method
Mar 7, 2025
Merged

feat: add checkpoint aget tuple method#281
averikitsch merged 2 commits intogoogleapis:langgraph-basefrom
carloszuag:feat/aget_tuple_method

Conversation

@carloszuag
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@carloszuag carloszuag requested review from a team March 6, 2025 20:30
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API. label Mar 6, 2025
@carloszuag carloszuag changed the title feat: add checkpoint aget_tuple method feat: add checkpoint aget tuple method Mar 6, 2025
@carloszuag carloszuag force-pushed the feat/aget_tuple_method branch from b176e37 to b67780d Compare March 6, 2025 20:38
@averikitsch
Copy link
Collaborator

/gcbrun

pyproject.toml Outdated
"pytest==8.3.3",
"pytest-cov==6.0.0"
"pytest-cov==6.0.0",
"Pillow==11.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Pillow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Pillow' has been removed

CHECKPOINT_WRITES_TABLE,
CHECKPOINTS_TABLE,
)
from langchain_google_cloud_sql_pg.engine import CHECKPOINTS_TABLE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove. not needed by the tests

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. This importation has been removed.

schema_name (str): The schema name to store the checkpoint tables.
Default: "public".
table_name (str): The PgSQL database table name.
Default: "CHECKPOINTS_TABLE".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update all to:

Suggested change
Default: "CHECKPOINTS_TABLE".
Default: "checkpoints".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. All the variable descriptions were replaced by "checkpoints".

@averikitsch
Copy link
Collaborator

averikitsch commented Mar 6, 2025

Lint error

tests/test_async_checkpoint.py:366: error: Argument "config" to "ainvoke" of "Pregel" has incompatible type "dict[str, dict[str, str]]"; expected "Optional[RunnableConfig]"  [arg-type]
tests/test_async_checkpoint.py:376: error: Argument 1 to "aget_tuple" of "AsyncPostgresSaver" has incompatible type "dict[str, dict[str, str]]"; expected "RunnableConfig"  [arg-type]

@carloszuag carloszuag requested a review from averikitsch March 7, 2025 16:22
@averikitsch
Copy link
Collaborator

/gcbrun

@averikitsch averikitsch merged commit 80cba45 into googleapis:langgraph-base Mar 7, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants