test(cloud-sql-admin): Create MCP integration tests#2985
Open
dishaprakash wants to merge 43 commits intomcp-cloud-sql-mssql-testsfrom
Open
test(cloud-sql-admin): Create MCP integration tests#2985dishaprakash wants to merge 43 commits intomcp-cloud-sql-mssql-testsfrom
dishaprakash wants to merge 43 commits intomcp-cloud-sql-mssql-testsfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive suite of integration tests for Cloud SQL Model Context Protocol (MCP) tools, covering operations such as cloning instances, creating backups, databases, and users, as well as listing and restoring resources. Several issues were identified in the new test files, including a missing fmt import in cloudsql_list_instances_mcp_test.go that will cause compilation errors, and a missing reflect import in cloud_sql_restore_backup_mcp_test.go. Additionally, it is recommended to use map-based deep comparison for JSON results in the restore backup tests to avoid fragility, and to standardize error handling in the operation wait tests using existing helper functions.
dishaprakash
force-pushed
the
mcp-cloud-sql-mssql-tests
branch
from
168c651 to
a52be69
Compare
dishaprakash
force-pushed
the
mcp-cloud-sql-mssql-tests
branch
from
a0fac99 to
d559003
Compare
dishaprakash
force-pushed
the
mcp-cloud-sql-admin-api-tests
branch
from
54da7cf to
735f4e7
Compare
dishaprakash
added
the
release candidate
dishaprakash
force-pushed
the
mcp-cloud-sql-mssql-tests
branch
3 times, most recently
from
5d605aa to
7dfd96a
Compare
anubhav756
added
priority: p1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Duplicated all Cloud SQL Admin API Tests with the new
mcp_tool.goharness for initialization and execution using MCP Endpoints