chore: implement floordiv_op compiler #1995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
tswast
reviewed
Aug 18, 2025
| # `inf`` for float in BQ so we short-circuit in this case. | ||
| # Multiplying left by zero propogates nulls. | ||
| zero_result = ( | ||
| constants._INF |
There was a problem hiding this comment.
Do we need to do -inf for negative values?
There was a problem hiding this comment.
The expression zero_result * left_expr below is able to correctly handle the -inf case. This is demonstrated by the screenshot, which compares the results from the Ibis and SQLGlot frameworks. The Ibis results are shown on the left, while the SQLGlot results are on the right. To be mentioned, the sqlglot SQL is not compact and pending for optimizations.
chelsea-lin
force-pushed
the
main_chelsealin_floordiv
branch
from
31b2d36 to
94b2ce9
Compare
chelsea-lin
force-pushed
the
main_chelsealin_floordiv
branch
from
a4e2bba to
ae69c7a
Compare
tswast
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 430133370 🦕