Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for diminished chords #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CasP0
Copy link

@CasP0 CasP0 commented Jan 21, 2025

Add support for diminished chords in the arpeggios application.

  • Notes.js

    • Add a new chord type "diminished" to the Notes object.
    • Add a loop to generate diminished chords for each key in Positions.majorOrder.
    • Add the generated diminished chords to the Notes.diminished object.
  • package.json

    • Add a new dependency for "diminished-chords" library.
  • README.md

    • Update the build instructions to include the new dependency.
    • Add a section listing the new dependency.

For more details, open the Copilot Workspace session.

Add support for diminished chords in the arpeggios application.

* **Notes.js**
  - Add a new chord type "diminished" to the `Notes` object.
  - Add a loop to generate diminished chords for each key in `Positions.majorOrder`.
  - Add the generated diminished chords to the `Notes.diminished` object.

* **package.json**
  - Add a new dependency for "diminished-chords" library.

* **README.md**
  - Update the build instructions to include the new dependency.
  - Add a section listing the new dependency.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/googlecreativelab/chrome-music-lab?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

google-cla bot commented Jan 21, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant