chore: remove place_id from getDetails fix

googlemaps · Dec 22, 2021 · 257e1ec · 257e1ec
1 parent 08b55c8
commit 257e1ec
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -40,7 +40,7 @@ service.getDetails({place_id: 'foo'})
 becomes
 
 ```js
-service.getDetails({fields: /** TODO: Add necessary fields to the request */ ['place_id'], place_id: 'foo'})
+service.getDetails({fields: /** TODO: Add necessary fields to the request */ [], place_id: 'foo'})
 ```
 
 ## Rules

diff --git a/docs/rules/place-fields.md b/docs/rules/place-fields.md
@@ -52,10 +52,10 @@ const service = new google.maps.places.Autocomplete(null, {fields: ['place_id']}
 🔧 Examples of code **fixed** by this rule:
 ```js
 const service = new google.maps.places.PlacesService(); /* → */ const service = new google.maps.places.PlacesService();
-service.getDetails({place_id: 'foo'})                   /* → */ service.getDetails({fields: /** TODO: Add necessary fields to the request */ ['place_id'], place_id: 'foo'})
+service.getDetails({place_id: 'foo'})                   /* → */ service.getDetails({fields: /** TODO: Add necessary fields to the request */ [], place_id: 'foo'})
 
 const service = new google.maps.places.PlacesService(); /* → */ const service = new google.maps.places.PlacesService();
-service.getDetails({...{place_id: 'foo'}})              /* → */ service.getDetails({fields: /** TODO: Add necessary fields to the request */ ['place_id'], ...{place_id: 'foo'}})
+service.getDetails({...{place_id: 'foo'}})              /* → */ service.getDetails({fields: /** TODO: Add necessary fields to the request */ [], ...{place_id: 'foo'}})
 ```
 
 ## Resources

diff --git a/src/rules/place-fields.test.ts b/src/rules/place-fields.test.ts
@@ -48,7 +48,7 @@ service.getDetails(buildRequest())`,
 service.getDetails({place_id: 'foo'})`,
       errors: [{ messageId }],
       output: `const service = new google.maps.places.PlacesService();
-service.getDetails({fields: /** TODO: Add necessary fields to the request */ ['place_id'], place_id: 'foo'})`,
+service.getDetails({fields: /** TODO: Add necessary fields to the request */ [], place_id: 'foo'})`,
     },
     {
       code: `const service = new google.maps.places.PlacesService();
@@ -61,7 +61,7 @@ service.getDetails(request)`,
 service.getDetails({...{place_id: 'foo'}})`,
       errors: [{ messageId }],
       output: `const service = new google.maps.places.PlacesService();
-service.getDetails({fields: /** TODO: Add necessary fields to the request */ ['place_id'], ...{place_id: 'foo'}})`,
+service.getDetails({fields: /** TODO: Add necessary fields to the request */ [], ...{place_id: 'foo'}})`,
     },
     // Autocomplete
     {

diff --git a/src/rules/place-fields.ts b/src/rules/place-fields.ts
@@ -103,7 +103,7 @@ export default createRule({
                                     context
                                       .getSourceCode()
                                       .getTokens(requestArgument)[1],
-                                    `fields: /** TODO: Add necessary fields to the request */ ['place_id'], `
+                                    `fields: /** TODO: Add necessary fields to the request */ [], `
                                   ),
                                 ];
                               }
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,7 +40,7 @@ service.getDetails({place_id: 'foo'}) @@
     becomes
     ```js
-    service.getDetails({fields: /** TODO: Add necessary fields to the request */ ['place_id'], place_id: 'foo'})
+    service.getDetails({fields: /** TODO: Add necessary fields to the request */ [], place_id: 'foo'})
     ```
     ## Rules
@@ Expand Down @@