Skip to content

Commit

Permalink
test: fixes and improves to integration tests (#264)
Browse files Browse the repository at this point in the history 
* test: fix color tests in integration tests

* ci: list installed system images after required images are installed for debugging purposes

* ci: fix avd starting issues

* tests: skip test fir navigating to multiple targets on android
  • Loading branch information
@jokerttu
jokerttu authored Feb 10, 2025
1 parent 333d36b commit a2745bf
Show file tree
Hide file tree
Showing 4 changed files with 149 additions and 121 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/test-and-build.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ jobs:

build-android:
name: Build Android
needs: [test-dart, test-android, test-ios]
needs: [test-dart, test-android]
if: contains(github.base_ref, 'main')
timeout-minutes: 45
runs-on:
Expand Down Expand Up @@ -171,7 +171,7 @@ jobs:

build-ios:
name: Build iOS
needs: [test-dart, test-android, test-ios]
needs: [test-dart, test-ios]
if: contains(github.base_ref, 'main')
timeout-minutes: 90
runs-on:
Expand Down Expand Up @@ -277,12 +277,12 @@ jobs:
run: flutter pub get
- name: Create and start emulator
run: |
echo "List installed packages"
$ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager --list_installed
echo "Installing system image"
echo "y" | $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager "system-images;android-35;google_apis;x86_64"
echo "Setting ANDROID_AVD_HOME"
export ANDROID_AVD_HOME=$HOME/.config/.android/avd
echo "Creating AVD"
echo "no" | $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/avdmanager create avd -n test_emulator -k "system-images;android-35;google_apis;x86_64" --force
Expand Down
14 changes: 14 additions & 0 deletions example/integration_test/shared.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -480,3 +480,17 @@ Future<Value?> waitForValueMatchingPredicate<Value>(PatrolIntegrationTester $,
}
return null;
}

// Convert a Color to an integer.
int? colorToInt(Color? color) {
if (color == null) {
return null;
}

int floatToInt8(double x) => (x * 255.0).round() & 0xff;

return (floatToInt8(color.a) << 24) |
(floatToInt8(color.r) << 16) |
(floatToInt8(color.g) << 8) |
(floatToInt8(color.b));
}
208 changes: 106 additions & 102 deletions example/integration_test/t03_navigation_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -144,122 +144,126 @@ void main() {
await GoogleMapsNavigator.cleanup();
});

patrol('Test navigating to multiple destinations',
(PatrolIntegrationTester $) async {
final Completer<void> navigationFinished = Completer<void>();
int arrivalEventCount = 0;

/// Set up navigation.
await startNavigationWithoutDestination($);

/// Set audio guidance settings.
/// Cannot be verified, because native SDK lacks getter methods,
/// but exercise the API for basic sanity testing
final NavigationAudioGuidanceSettings settings =
NavigationAudioGuidanceSettings(
isBluetoothAudioEnabled: false,
isVibrationEnabled: false,
guidanceType: NavigationAudioGuidanceType.alertsOnly,
);
await GoogleMapsNavigator.setAudioGuidance(settings);

/// Specify tolerance and navigation destination coordinates.
const double tolerance = 0.001;
const double midLat = 68.59781164189049,
midLon = 23.520303427087182,
endLat = 68.60079240808535,
endLng = 23.527946512754752;

Future<void> onArrivalEvent(OnArrivalEvent msg) async {
arrivalEventCount += 1;
await GoogleMapsNavigator.continueToNextDestination();

/// Finish executing the tests once 2 onArrival events come in.
/// Test the guidance stops on last Arrival.
if (arrivalEventCount == 2) {
navigationFinished.complete();
patrol(
'Test navigating to multiple destinations',
(PatrolIntegrationTester $) async {
final Completer<void> navigationFinished = Completer<void>();
int arrivalEventCount = 0;

/// Set up navigation.
await startNavigationWithoutDestination($);

/// Set audio guidance settings.
/// Cannot be verified, because native SDK lacks getter methods,
/// but exercise the API for basic sanity testing
final NavigationAudioGuidanceSettings settings =
NavigationAudioGuidanceSettings(
isBluetoothAudioEnabled: false,
isVibrationEnabled: false,
guidanceType: NavigationAudioGuidanceType.alertsOnly,
);
await GoogleMapsNavigator.setAudioGuidance(settings);

/// Specify tolerance and navigation destination coordinates.
const double tolerance = 0.001;
const double midLat = 68.59781164189049,
midLon = 23.520303427087182,
endLat = 68.60079240808535,
endLng = 23.527946512754752;

Future<void> onArrivalEvent(OnArrivalEvent msg) async {
arrivalEventCount += 1;
await GoogleMapsNavigator.continueToNextDestination();

/// Finish executing the tests once 2 onArrival events come in.
/// Test the guidance stops on last Arrival.
if (arrivalEventCount == 2) {
navigationFinished.complete();
}
}
}

GoogleMapsNavigator.setOnArrivalListener(onArrivalEvent);
GoogleMapsNavigator.setOnArrivalListener(onArrivalEvent);

/// Simulate location and test it.
await GoogleMapsNavigator.simulator.setUserLocation(const LatLng(
latitude: startLat,
longitude: startLng,
));
await $.pumpAndSettle(timeout: const Duration(seconds: 1));
/// Simulate location and test it.
await GoogleMapsNavigator.simulator.setUserLocation(const LatLng(
latitude: startLat,
longitude: startLng,
));
await $.pumpAndSettle(timeout: const Duration(seconds: 1));

/// Set Destination.
final Destinations destinations = Destinations(
waypoints: <NavigationWaypoint>[
NavigationWaypoint.withLatLngTarget(
title: 'Näkkäläntie 1st stop',
target: const LatLng(
latitude: midLat,
longitude: midLon,
/// Set Destination.
final Destinations destinations = Destinations(
waypoints: <NavigationWaypoint>[
NavigationWaypoint.withLatLngTarget(
title: 'Näkkäläntie 1st stop',
target: const LatLng(
latitude: midLat,
longitude: midLon,
),
),
),
NavigationWaypoint.withLatLngTarget(
title: 'Näkkäläntie 2nd stop',
target: const LatLng(
latitude: endLat,
longitude: endLng,
NavigationWaypoint.withLatLngTarget(
title: 'Näkkäläntie 2nd stop',
target: const LatLng(
latitude: endLat,
longitude: endLng,
),
),
),
],
displayOptions: NavigationDisplayOptions(showDestinationMarkers: false),
);
final NavigationRouteStatus status =
await GoogleMapsNavigator.setDestinations(destinations);
expect(status, NavigationRouteStatus.statusOk);
await $.pumpAndSettle();
],
displayOptions: NavigationDisplayOptions(showDestinationMarkers: false),
);
final NavigationRouteStatus status =
await GoogleMapsNavigator.setDestinations(destinations);
expect(status, NavigationRouteStatus.statusOk);
await $.pumpAndSettle();

expect(await GoogleMapsNavigator.isGuidanceRunning(), false);
expect(await GoogleMapsNavigator.isGuidanceRunning(), false);

/// Start guidance.
await GoogleMapsNavigator.startGuidance();
await $.pumpAndSettle();
/// Start guidance.
await GoogleMapsNavigator.startGuidance();
await $.pumpAndSettle();

/// Test that the received coordinates fit between start and end location coordinates within tolerance.
void onLocationEvent(RoadSnappedLocationUpdatedEvent msg) {
/// Sometimes on Android, the simulator "overshoots" and passes the destination
/// with high speedMultiplier.
if (arrivalEventCount < 2) {
expectSync(
msg.location.latitude,
greaterThanOrEqualTo(startLat - tolerance),
);
expectSync(
msg.location.latitude,
lessThanOrEqualTo(endLat + tolerance),
);
expectSync(
msg.location.longitude,
greaterThanOrEqualTo(startLng - tolerance),
);
expectSync(
msg.location.longitude,
lessThanOrEqualTo(endLng + tolerance),
);
/// Test that the received coordinates fit between start and end location coordinates within tolerance.
void onLocationEvent(RoadSnappedLocationUpdatedEvent msg) {
/// Sometimes on Android, the simulator "overshoots" and passes the destination
/// with high speedMultiplier.
if (arrivalEventCount < 2) {
expectSync(
msg.location.latitude,
greaterThanOrEqualTo(startLat - tolerance),
);
expectSync(
msg.location.latitude,
lessThanOrEqualTo(endLat + tolerance),
);
expectSync(
msg.location.longitude,
greaterThanOrEqualTo(startLng - tolerance),
);
expectSync(
msg.location.longitude,
lessThanOrEqualTo(endLng + tolerance),
);
}
}
}

await GoogleMapsNavigator.setRoadSnappedLocationUpdatedListener(
onLocationEvent);
await GoogleMapsNavigator.setRoadSnappedLocationUpdatedListener(
onLocationEvent);

/// Start simulation.
await GoogleMapsNavigator.simulator
.simulateLocationsAlongExistingRouteWithOptions(SimulationOptions(
speedMultiplier: 10,
));
/// Start simulation.
await GoogleMapsNavigator.simulator
.simulateLocationsAlongExistingRouteWithOptions(SimulationOptions(
speedMultiplier: 10,
));

expect(await GoogleMapsNavigator.isGuidanceRunning(), true);
await navigationFinished.future;
expect(await GoogleMapsNavigator.isGuidanceRunning(), false);
expect(await GoogleMapsNavigator.isGuidanceRunning(), true);
await navigationFinished.future;
expect(await GoogleMapsNavigator.isGuidanceRunning(), false);

await GoogleMapsNavigator.cleanup();
});
await GoogleMapsNavigator.cleanup();
},
// TODO(jokerttu): Skipping Android as this fails on Android emulator on CI.
skip: Platform.isAndroid,
);

patrol('Test simulation along new route', (PatrolIntegrationTester $) async {
int loopIteration = 1;
Expand Down
38 changes: 24 additions & 14 deletions example/integration_test/t08_marker_polygon_polyline_circle_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,8 @@ void main() {
polylines[0]!.options.points![1].longitude, closeTo(25.929471, 0.01));
expect(polylines[0]!.options.clickable, true);
expect(polylines[0]!.options.geodesic, true);
expect(polylines[0]!.options.strokeColor!, Colors.red);
expect(
colorToInt(polylines[0]!.options.strokeColor!), colorToInt(Colors.red));
expect(polylines[0]!.options.strokeWidth, 5.0);

/// iOS doesn't have strokeJointTypes
Expand Down Expand Up @@ -343,7 +344,8 @@ void main() {
expect(receivedPolylines.length, 1);
expect(receivedPolylines[0]!.options.geodesic, false);
expect(receivedPolylines[0]!.options.clickable, false);
expect(receivedPolylines[0]!.options.strokeColor!, Colors.black);
expect(colorToInt(receivedPolylines[0]!.options.strokeColor!),
colorToInt(Colors.black));
expect(receivedPolylines[0]!.options.strokeWidth, 10.0);

/// iOS doesn't have strokeJointTypes
Expand Down Expand Up @@ -578,9 +580,9 @@ void main() {

// Default values.
expect(polygon.options.clickable, false);
expect(polygon.options.fillColor, Colors.black);
expect(colorToInt(polygon.options.fillColor), colorToInt(Colors.black));
expect(polygon.options.geodesic, false);
expect(polygon.options.strokeColor, Colors.black);
expect(colorToInt(polygon.options.strokeColor), colorToInt(Colors.black));
expect(polygon.options.strokeWidth, 10);
expect(polygon.options.visible, true);
expect(polygon.options.zIndex, 0);
Expand Down Expand Up @@ -660,9 +662,11 @@ void main() {
expect(updatedPolygon.options.points, updatedOptions.points);
expect(updatedPolygon.options.holes, updatedOptions.holes);
expect(updatedPolygon.options.clickable, updatedOptions.clickable);
expect(updatedPolygon.options.fillColor, updatedOptions.fillColor);
expect(colorToInt(updatedPolygon.options.fillColor),
colorToInt(updatedOptions.fillColor));
expect(updatedPolygon.options.geodesic, updatedOptions.geodesic);
expect(updatedPolygon.options.strokeColor, updatedOptions.strokeColor);
expect(colorToInt(updatedPolygon.options.strokeColor),
colorToInt(updatedOptions.strokeColor));
expect(updatedPolygon.options.strokeWidth, updatedOptions.strokeWidth);
expect(updatedPolygon.options.visible, updatedOptions.visible);
expect(updatedPolygon.options.zIndex, updatedOptions.zIndex);
Expand All @@ -687,9 +691,11 @@ void main() {

for (final Polygon polygon in polygonList2) {
expect(polygon.options.clickable, updatedOptions.clickable);
expect(polygon.options.fillColor, updatedOptions.fillColor);
expect(colorToInt(polygon.options.fillColor),
colorToInt(updatedOptions.fillColor));
expect(polygon.options.geodesic, updatedOptions.geodesic);
expect(polygon.options.strokeColor, updatedOptions.strokeColor);
expect(colorToInt(polygon.options.strokeColor),
colorToInt(updatedOptions.strokeColor));
expect(polygon.options.strokeWidth, updatedOptions.strokeWidth);
expect(polygon.options.visible, updatedOptions.visible);
expect(polygon.options.zIndex, updatedOptions.zIndex);
Expand Down Expand Up @@ -814,8 +820,8 @@ void main() {

// Default values.
expect(circle.options.clickable, false);
expect(circle.options.fillColor, Colors.black);
expect(circle.options.strokeColor, Colors.black);
expect(colorToInt(circle.options.fillColor), colorToInt(Colors.black));
expect(colorToInt(circle.options.strokeColor), colorToInt(Colors.black));
expect(circle.options.strokeWidth, 10);
expect(circle.options.strokePattern, circle.options.strokePattern);
expect(circle.options.visible, true);
Expand Down Expand Up @@ -862,8 +868,10 @@ void main() {
expect(updatedCircle.options.position, updatedOptions.position);
expect(updatedCircle.options.radius, updatedOptions.radius);
expect(updatedCircle.options.clickable, updatedOptions.clickable);
expect(updatedCircle.options.fillColor, updatedOptions.fillColor);
expect(updatedCircle.options.strokeColor, updatedOptions.strokeColor);
expect(colorToInt(updatedCircle.options.fillColor),
colorToInt(updatedOptions.fillColor));
expect(colorToInt(updatedCircle.options.strokeColor),
colorToInt(updatedOptions.strokeColor));
expect(updatedCircle.options.strokeWidth, updatedOptions.strokeWidth);
expect(updatedCircle.options.strokePattern, updatedOptions.strokePattern);
expect(updatedCircle.options.visible, updatedOptions.visible);
Expand Down Expand Up @@ -891,9 +899,11 @@ void main() {
expect(circle.options.position, updatedOptions.position);
expect(circle.options.radius, updatedOptions.radius);
expect(circle.options.clickable, updatedOptions.clickable);
expect(circle.options.fillColor, updatedOptions.fillColor);
expect(colorToInt(circle.options.fillColor),
colorToInt(updatedOptions.fillColor));
expect(circle.options.strokePattern, updatedOptions.strokePattern);
expect(circle.options.strokeColor, updatedOptions.strokeColor);
expect(colorToInt(circle.options.strokeColor),
colorToInt(updatedOptions.strokeColor));
expect(circle.options.strokeWidth, updatedOptions.strokeWidth);
expect(circle.options.visible, updatedOptions.visible);
expect(circle.options.zIndex, updatedOptions.zIndex);
Expand Down

0 comments on commit a2745bf

Please sign in to comment.