fix: ios view registration race condition #555
Merged
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokerttu
reviewed
Dec 10, 2025
..._navigation_flutter/Sources/google_navigation_flutter/GoogleMapsNavigationViewRegistry.swift
Outdated
Show resolved
Hide resolved
jokerttu
approved these changes
Dec 10, 2025
Contributor
There was a problem hiding this comment.
Added one naming nit
And code format check fails
Otherwise LGTM
…r/GoogleMapsNavigationViewRegistry.swift Co-authored-by: Joonas Kerttula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to iOS view registration logic that previously caused some issues like onViewCreated not being triggered on iOS when doing hot restart with Flutter.
Fixes: #541
Fix based on a code suggestion from user @bderrien
Pre-launch Checklist