fix: linting error caused by not enforcing key type for dictionary #140

googlemaps · Apr 29, 2024 · 9960a8a · 9960a8a
1 parent 62f9a5f
commit 9960a8a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/components/navigation/navigationView/index.tsx b/components/navigation/navigationView/index.tsx
@@ -41,7 +41,7 @@ import {ArrivalEvent, NavigationViewProps} from './types';
 export default class NavigationView extends React.Component<NavigationViewProps> {
   private viewId: number = -1;
   private mapViewRef?: any;
-  private nativeEventsToCallbackMap;
+  private nativeEventsToCallbackMap: { [key: string] : (event: any) => void };
 
   constructor(_props: NavigationViewProps) {
     super(_props);
@@ -361,7 +361,10 @@ export default class NavigationView extends React.Component<NavigationViewProps>
     );
 
     for (const eventName of Object.keys(this.nativeEventsToCallbackMap)) {
-      eventEmitter.addListener(eventName, this.nativeEventsToCallbackMap[eventName]);
+      const listener = this.nativeEventsToCallbackMap[eventName];
+      if (listener != undefined) {
+        eventEmitter.addListener(eventName, listener);
+      }
     }
   };
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-navigation-sdk",
-  "version": "0.3.0-beta",
+  "version": "0.3.1-beta",
   "author": "Google",
   "description": "A react-native library for Google's Navigation SDK",
   "private": false,

diff --git a/tsconfig.json b/tsconfig.json
@@ -18,8 +18,8 @@
     "forceConsistentCasingInFileNames": true,
     "noFallthroughCasesInSwitch": true,
     "noImplicitOverride": true,
-    "allowUnreachableCode": false,
-    "noImplicitAny": false,
+    "allowUnreachableCode": true,
+    "noImplicitAny": true,
     "moduleSuffixes": [".android", ".ios", ""]
   },
   "include": [