Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 0.5.0 #244

Merged
merged 1 commit into from
Sep 4, 2024
Merged

chore: release 0.5.0 #244

merged 1 commit into from
Sep 4, 2024

Conversation

jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Sep 3, 2024

Release-As: 0.5.0

Release-As: 0.5.0
@jokerttu
Copy link
Contributor Author

jokerttu commented Sep 3, 2024

@wangela

It seems that Release Please automatically upgraded the version number to 1.0.0 (still in PR) due to the breaking change (denoted by the feat! commit). However, since this project is still in beta/preview, the version should probably be 0.5.0 instead.

Should we modify the existing release-please PR (#243) to adjust the version number to 0.5.0, or should we handle this with a separate commit in this PR as suggested in the Release Please README?

@wangela
Copy link
Member

wangela commented Sep 4, 2024

Empty commit like this. Next time, you can add the Release-As: x.x.x to your merge commit message in the PR that contains a feat: fix: or breaking change (e.g. would have been #239 in this case) to specify the version number.

@jokerttu jokerttu merged commit d24855b into main Sep 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants