Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVE: implement live reloading using browser-sync #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asamolion
Copy link

Hi there,

I used your plugin to develop a React based plugin on WP. Excellent work btw, yours was the only build I found that was usable in integrating WP and React!

But I found that I had to refresh the page after each change in the plugin's React code, so I've implemented a basic version of live reloading using browser-sync.

Please let me know if this needs any improvements.

Regards.

@DevinWalker
Copy link

Is this project dead? Seems like this PR would get some love if not...

@dnusca
Copy link
Contributor

dnusca commented Jul 12, 2019

Hey @DevinWalker,

It is a bit stale, I'm hoping to bring it inline with JS practices used in Gutenberg as well as support blocks. That said, this might happen under a different project as I will probably be dropping shortcodes and widgets.

Initially we were still deciding whether to implement this, as we were also looking at hot reloading and I guess it just fell by the wayside.

I'm locked down at the moment, but will try take a look at the end of next week.

@dnusca
Copy link
Contributor

dnusca commented Jul 12, 2019

If @asamolion can resolve the conflicts from the updated dependencies and regenerate the yarn.lock file then I'll merge as soon as I get the notification.

@DevinWalker
Copy link

@dnusca it is a cool looking project. I agree on dropping shortcodes and widgets to support blocks. Would love to see a revival here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants