Add progress marker toggle in EPUB reader #1915
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rinbadagin
changed the title
Rinbadagin
force-pushed
the
add_epub_progress_marker_toggle
branch
from
e719996 to
d428010
Compare
|
Just amended the PR to keep the current section name visible if known in the case where progress markers are off. |
gotson
reviewed
Mar 17, 2025
komga-webui/src/views/EpubReader.vue
Outdated
| }, | ||
| set: function (value: boolean): void { | ||
| this.settings.progressMarkers = value | ||
| this.$store.commit('setWebreaderProgressMarkers', value) |
There was a problem hiding this comment.
that's not gonna do anything if there's no store action with that name. For the Epub reader, a single settings object is persisted with all the keys, like this.$store.commit('setEpubreaderSettings', this.settings)
There was a problem hiding this comment.
My bad - force pushed to adjust
Rinbadagin
force-pushed
the
add_epub_progress_marker_toggle
branch
from
d428010 to
d6a37e6
Compare
|
I'm wondering whether providing more options than just on/off would be better? I think on Kobo you can decide what to display where, or cycle through a few options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a toggle to hide/show the progress markers visible on the bottom of the viewer in EPUB files.
Settings post-change:
Page markers on (default, existing behaviour):
Page markers off (current progressionTitle falsy):
Page markers off (current progressionTitle truthy):