Skip to content

Conversation

@raprism
Copy link

@raprism raprism commented Mar 27, 2024

Hi,

I would suggest to flip module names, because Python3 should be de facto the standard version now.

There is a fix in new isfread.py (formerly isfread_py3.py, so that a specific data example from current TBS1000C, which has BYT_N equal to 1, was converted apparently without errors.

@gpasquev
Copy link
Owner

gpasquev commented Apr 2, 2024

Hi RA,

Thank you for the commit. I will review it shortly. I began working on this code some time ago,
and I only maintain it occasionally. Currently, it helps as a valuable tool for enhancing my skills with Git and GitHub.

I noticed you explicitly mentioned the 'a-card' branch. Could you please elaborate on why this mention is necessary?
Does this branch follow a different approach? Have you tested it and found it to be an alternative option? Since I haven't had a chance to test it myself, I don't have those answers.

I noticed that several lines have been removed from the original isfread_py3.py. Before accepting these changes, I'll need to check what they do.

Do you want me to mention you in code as RA, or would you prefer a more explicit mention?

Thank you again, and I am open to any suggestions.

Please note that English is not my native language. Feel free to respond by email if you prefer. My email is included in the .py files.

@raprism
Copy link
Author

raprism commented Apr 13, 2024

Hi Gustavo,

thank you for your quick response that I noticed only now.

The a-card fork was mentioned by me, because from one of the older py3 versions I took the idea to use the with statement for fileInput opening. (Then closing takes places automatically, so fileInput.close() is not needed anymore.)

Later on I merged this back to your py3 version for my own use.

There are no removed lines compared to your code! I shifted the def cmp(a, b): block up, and then follows with open(filename,'rb') as fileInput: with then identical code to your version. Because there is an additional indentation, the block / code is not recognized as identical by diff, but it is.

There is only the different way of file opening (with implicit, automatic closing of fileInput) and the small addition for the bytenum=1 case. And of course the file name changes.

If you want you can mention my contribution with my full name. It's not absolutely necessary to keep this mention in the author tag or in the file at all. There is still the git log ...

Thank you for your work to provide isfread for python!

Regards
Ralf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants