Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: react 19 migration #747

Merged
merged 4 commits into from
Jan 27, 2025
Merged

fix: react 19 migration #747

merged 4 commits into from
Jan 27, 2025

Conversation

spaenleh
Copy link
Member

In this PR:

  • Migrate to react 19
  • Switch to react-quill-new from react-quill since it supports react19
  • run the codemod to fix the JSX namespace changes
  • fix some refs issues
  • fix some types from ReactElement<any> to ReactNode which is better in a lot of cases.

close #746

@spaenleh spaenleh requested a review from pyphilia January 27, 2025 08:30
@spaenleh spaenleh self-assigned this Jan 27, 2025
@spaenleh spaenleh added the dependencies Pull requests that update a dependency file label Jan 27, 2025
@spaenleh spaenleh mentioned this pull request Jan 27, 2025
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge 🐘

@spaenleh spaenleh added this pull request to the merge queue Jan 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2025
@spaenleh spaenleh merged commit f37ed27 into main Jan 27, 2025
5 checks passed
@spaenleh spaenleh deleted the react-19 branch January 27, 2025 12:01
spaenleh added a commit that referenced this pull request Feb 6, 2025
* feat: most used apps hook

* fix: update hook

* fix: update hook key

* fix: update hook key

* feat: update hook

* fix: unused variables

* fix: update hooks

* fix: update hook

* fix: update hook

* fix: update hook

* fix: update field name

* fix: update key

* fix: formatting

---------

Co-authored-by: spaenleh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file v2.19.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to react 19
2 participants