Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use update password generation to fix translation #940

Merged
merged 5 commits into from
Mar 3, 2025
Merged

fix: use update password generation to fix translation #940

merged 5 commits into from
Mar 3, 2025

Conversation

pyphilia
Copy link
Contributor

I replace the updatePassword and createPassword endpoints to avoid using notifier.

ref #819

@pyphilia pyphilia self-assigned this Feb 19, 2025
@pyphilia pyphilia force-pushed the 819-notifier-edit-password branch from 6bfe07f to 3d38148 Compare February 25, 2025 15:02
@pyphilia pyphilia marked this pull request as ready for review February 25, 2025 15:03
@pyphilia pyphilia requested a review from spaenleh February 28, 2025 12:51
spaenleh
spaenleh requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I am just not sure why you removed the email validation function to use the one from the validator package ? I tried to remove the dependency on that package by copying only the validation function we used into sdk.

@pyphilia pyphilia requested a review from spaenleh March 3, 2025 12:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pyphilia pyphilia merged commit e4b0e71 into main Mar 3, 2025
5 checks passed
@pyphilia pyphilia deleted the 819-notifier-edit-password branch March 3, 2025 14:35
@graasper graasper mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
v2.22.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @spaenleh